Remove dead code surfaced by review (pub items with no callers) #15

Closed
opened 2026-06-05 10:26:31 +00:00 by victor · 0 comments
Owner

The crate compiles clean (-D warnings), but these pub/pub(crate) items escape dead-code analysis and have zero callers:

High confidence (safe to remove):

  • JsonRpcResponse::internal_error — src/mcp/protocol.rs:56-59. Carries the only #[allow(dead_code)] in src/; no callers (sibling constructors are used). Remove the method and the #[allow].
  • tag_description_path — src/core/storage/mod.rs:201-204. Reorg alias; zero callers (forwards to tag_meta_path).
  • Task::is_open — src/core/domain/task.rs:256-259. Zero callers (siblings is_hidden/is_active used).

Medium (redundant reorg re-exports):

  • pub use resolve::resolve_task_id; and pub use config::Config; in src/core/mod.rs — every caller uses the full path or the crate-root re-export; these module-root re-exports are unused.

Leave store_mut and core::{Result,TaskError} re-exports (plausibly intentional API surface) unless deliberately trimming. No unused dependencies found.

Found in review.

The crate compiles clean (-D warnings), but these `pub`/`pub(crate)` items escape dead-code analysis and have zero callers: **High confidence (safe to remove):** - `JsonRpcResponse::internal_error` — src/mcp/protocol.rs:56-59. Carries the only `#[allow(dead_code)]` in src/; no callers (sibling constructors are used). Remove the method and the `#[allow]`. - `tag_description_path` — src/core/storage/mod.rs:201-204. Reorg alias; zero callers (forwards to `tag_meta_path`). - `Task::is_open` — src/core/domain/task.rs:256-259. Zero callers (siblings `is_hidden`/`is_active` used). **Medium (redundant reorg re-exports):** - `pub use resolve::resolve_task_id;` and `pub use config::Config;` in src/core/mod.rs — every caller uses the full path or the crate-root re-export; these module-root re-exports are unused. Leave `store_mut` and `core::{Result,TaskError}` re-exports (plausibly intentional API surface) unless deliberately trimming. No unused dependencies found. Found in review.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
victor/task-manager#15
No description provided.